Add Mac os x installation scripts by nsryan2 · Pull Request #46 · pyne/install_scripts

nsryan2 · 2020-08-10T20:22:40Z

This PR adds a macosx.sh file (which is a replica of the the ubuntu_mint.sh) and a osx_10.15.06.sh file (which is a replica of the ubuntu_16.04.sh file). They have been adapted to hopefully work on mac.

Update 1

…ackages Packages replaced: - build-essential - python-software-properties - software-properties-common These packages are not for MacOS, and are not available through brew install or pip, so I went through the different parts of them and picked out what seemed to be relavent (as well as what was able to be installed through brew and pip) to Mac and added it.

bam241

small problem pip

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

osx_10.15.6.sh

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

macosx.sh

bam241 · 2020-08-11T17:25:06Z

you also need to change the permission of macosx.sh and ox.????.sh scripts to executable

I accidentially pushed to the wrong branch

gonuke · 2020-08-11T18:41:28Z

You'll want to exclude the .DS_Store file/directory from your PR. Also might be useful to keep the shell script and dockerfile in different PRs. I think docker may be even more challenging...

nsryan2 · 2020-08-11T18:49:25Z

My bad, I pushed changes to the wrong branch when I changed the permissions so those got wrapped up in it. I thought I deleted that dockerfile. Thanks for the note

…into some_fix

Some various fix

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241

LGTM! thx @nsryan2

gonuke

For long term maintenance purposes, I'm comparing this to the ubuntu_mint version. Are all differences strictly necessary?

gonuke · 2020-08-12T19:10:56Z

macosx.sh

+              -DCMAKE_INSTALL_PREFIX=${install_dir}/moab
+    make
+    make install
+


Difference from Ubuntu: why not update the ENV Variables directly here (instead of sourcing .bashrc below)?

I think we should update the linux version accordingly:

I see 2 advantages:

simplify the scripts

allow to check if .bashrc if properly formed

macosx.sh

gonuke · 2020-08-12T19:13:47Z

macosx.sh

+        TAG=$(git describe --abbrev=0 --tags)
+        git checkout tags/`echo $TAG` -b `echo $TAG`
+    fi
+    python setup.py install --user -- -DMOAB_LIBRARY=$install_dir/moab/lib -DMOAB_INCLUDE_DIR=$install_dir/moab/include


This looks like an "old-fashioned" way to configure setup.py. Why not the --moab and --dagmc options? Also, no DAGMC? Is that not possible?

fixing this right now

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

macosx.sh

this should be the last one

convergence in macos and ubuntu scripts

macosx.sh

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

gonuke · 2020-08-15T15:08:18Z

An item to confirm/test for @bam241 or @nsryan2:

we currently prevent building of the spatial solvers on macOS, apparently in 2 separate places: https://github.com/pyne/pyne/blob/develop/src/CMakeLists.txt#L67 and https://github.com/pyne/pyne/blob/develop/cmake/PyneMacros.cmake#L151

Do we need both of these, or can we rely on the one in PyneMacros?

Can we actually support building the spatial solvers on MacOS? This may be a more challenging question.

nsryan2 · 2020-09-01T04:22:27Z

I keep getting the error asking for a stdio.h file, but I'm not sure how to make or install one. This failure happens in the moab part of the install, is there a package or file I can install separately to prevent this?

/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/stdio.h:107:15: fatal error:
'stdio.h' file not found
#include_next <stdio.h>
^~~~~~~~~
1 error generated.
error: command '/Library/Developer/CommandLineTools/usr/bin/cc' failed with exit status 1
make[2]: *** [pymoab/CMakeFiles/pymoab-local-install] Error 1
make[1]: *** [pymoab/CMakeFiles/pymoab-local-install.dir/all] Error 2
make: *** [all] Error 2

Edit:
Upon further examination, I do have a couple stdio.h files, one of which is located at /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/stdio.h

katyhuff · 2020-09-01T13:29:00Z

Double check your installation of xcode's command-line tools. frida/frida#338

nsryan2 and others added 5 commits August 10, 2020 13:05

Merge pull request #1 from pyne/main

60efffc

Update 1

create a macosx sh file

f14554f

Create macosx install script from mint script

eabc212

change dependency list name

401d66e

bam241 requested changes Aug 10, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

macosx.sh Outdated Show resolved Hide resolved

nsryan2 and others added 2 commits August 10, 2020 16:05

Apply suggestions from code review

7432182

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

Update build moab script and add build dagmc to operate with cmake

48abe72

bam241 reviewed Aug 10, 2020

View reviewed changes

osx_10.15.6.sh Outdated Show resolved Hide resolved

Add eigen to list of brew package installs

1d3b0d8

bam241 reviewed Aug 10, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

nsryan2 added 3 commits August 11, 2020 08:46

Add hdf5 to the packages

df3f162

Remove references to hdf5_libdir

655ac35

Remove references to hdf5_libdir

798a948

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

Apply suggestions from code review

8fa80d8

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

Update macosx.sh

0892a60

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

Update macosx.sh

de30a2c

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Show resolved Hide resolved

Apply suggestions from code review

e1b4d0e

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241 reviewed Aug 11, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

Remove reference to python 2

d0ef93a

nsryan2 and others added 3 commits August 11, 2020 13:15

add chmod=+x to the install_scripts folder

234e758

Merge branch 'add_mac' into main

cadaae6

Merge pull request #2 from nsryan2/main

cfb92d1

I accidentially pushed to the wrong branch

nsryan2 added 2 commits August 11, 2020 13:46

Delete osx_10.15.6-stable.dockerfile

6542c38

Delete .DS_Store

a66978b

bam241 and others added 4 commits August 12, 2020 09:17

this should now be working

7c30f01

Merge branch 'add_mac' of https://github.com/nsryan2/install_scripts …

7f9cbba

…into some_fix

cleaning

71b765e

Merge pull request #3 from bam241/some_fix

d0ad7a6

Some various fix

nsryan2 requested a review from bam241 August 12, 2020 14:28

bam241 reviewed Aug 12, 2020

View reviewed changes

macosx.sh Show resolved Hide resolved

Update macosx.sh

3d32f49

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241 requested a review from gonuke August 12, 2020 18:20

bam241 approved these changes Aug 12, 2020

View reviewed changes

gonuke requested changes Aug 12, 2020

View reviewed changes

bam241 reviewed Aug 12, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

Update macosx.sh

b6f7e77

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

bam241 reviewed Aug 14, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

nsryan2 and others added 5 commits August 14, 2020 12:05

Add the curly brackets around variables

e1facd1

this should be the last one

1f4b113

Merge pull request #5 from bam241/some_fix

266a31a

this should be the last one

convergence in macos and ubuntu scripts

2e4facc

Merge pull request #6 from gonuke/add_mac

b6a126c

convergence in macos and ubuntu scripts

bam241 reviewed Aug 14, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

bam241 reviewed Aug 14, 2020

View reviewed changes

macosx.sh Outdated Show resolved Hide resolved

Apply suggestions from code review

1c06a88

Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>

Conversation

nsryan2 commented Aug 10, 2020

Uh oh!

bam241 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bam241 commented Aug 11, 2020

Uh oh!

gonuke commented Aug 11, 2020

Uh oh!

nsryan2 commented Aug 11, 2020

Uh oh!

Uh oh!

bam241 left a comment

Choose a reason for hiding this comment

Uh oh!

gonuke left a comment

Choose a reason for hiding this comment

Uh oh!

gonuke Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

bam241 Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gonuke Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

bam241 Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gonuke commented Aug 15, 2020

Uh oh!

nsryan2 commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katyhuff commented Sep 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nsryan2 commented Sep 1, 2020 •

edited

Loading